netdev - Re: [PATCH net] gro_cells: reduce number of synchronize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201125113154.739bc908@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 25 Nov 2020 11:31:54 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net] gro_cells: reduce number of synchronize_net() calls

On Tue, 24 Nov 2020 12:38:22 -0800 Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> After cited commit, gro_cells_destroy() became damn slow
> on hosts with a lot of cores.
> 
> This is because we have one additional synchronize_net() per cpu as
> stated in the changelog.
> 
> gro_cells_init() is setting NAPI_STATE_NO_BUSY_POLL, and this was enough
> to not have one synchronize_net() call per netif_napi_del()
> 
> We can factorize all the synchronize_net() to a single one,
> right before freeing per-cpu memory.
> 
> Fixes: 5198d545dba8 ("net: remove napi_hash_del() from driver-facing API")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thank you!