netdev - Re: [PATCH net-next v5 08/14] net/smc: Introduce generic netlink interface for diagnostic purposes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201125161802.402912b2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 25 Nov 2020 16:18:02 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Karsten Graul <kgraul@...ux.ibm.com>
Cc:     David Miller <davem@...emloft.net>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Stefan Raspl <raspl@...ux.ibm.com>, netdev@...r.kernel.org,
        linux-s390@...r.kernel.org
Subject: Re: [PATCH net-next v5 08/14] net/smc: Introduce generic netlink
 interface for diagnostic purposes

On Tue, 24 Nov 2020 18:50:41 +0100 Karsten Graul wrote:
> From: Guvenc Gulce <guvenc@...ux.ibm.com>
> 
> Introduce generic netlink interface infrastructure to expose
> the diagnostic information regarding smc linkgroups, links and devices.
> 
> Signed-off-by: Guvenc Gulce <guvenc@...ux.ibm.com>
> Signed-off-by: Karsten Graul <kgraul@...ux.ibm.com>

> @@ -2494,6 +2495,7 @@ static int __init smc_init(void)
>  
>  	smc_ism_init();
>  	smc_clc_init();
> +	smc_nl_init();

This can fail.

> +static const struct nla_policy smc_gen_nl_policy[SMC_GEN_MAX + 1] = {
> +	[SMC_GEN_UNSPEC]	= { .type = NLA_UNSPEC, },

This is unnecessary, NLA_UNSPEC is 0.

> +};