netdev - struct mii_if_info in usbnet.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <986e95f8d75780ddeda90e135237eccf1d9b1e55.camel@suse.com>
Date:   Thu, 26 Nov 2020 15:59:37 +0100
From:   Oliver Neukum <oneukum@...e.com>
To:     linux-usb@...r.kernel.org, netdev@...r.kernel.org
Cc:     hayeswang@...ltek.com, hkallweit1@...il.com, tremyfr@...il.com
Subject: struct mii_if_info in usbnet.h

Hi,

I was looking at usbnet_get_link_ksettings() and it seems in hindsight
that the idea it rests upon makes an assumption about the hardware
that was at the time it was introduced was often true, but today
isn't.

struct usbnet contains a member struct mii_if_info. Why? That makes
a pretty strong assumption about the hardware. Inparticular I see
no way to sanely implement mdio_read() and mdio_write() on hardware
this assumption does not fit.

On this hardware usbnet_get_link_ksettings() does not do its job.
So what is to be done? Technically it is a layering violation. Yet
it is obviously useful to many drivers?
Suggestions?

	Regards
		Oliver