netdev - Re: [PATCH net-next 1/3] nfc: s3fwrn5: use signed integer for parsing GPIO numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEx-X7esGyZ2QiTGbE1H7M7z1dqT47awmqrOtN+p0FbwtwfPOg@mail.gmail.com>
Date:   Fri, 27 Nov 2020 07:53:32 +0900
From:   Bongsu Jeon <bs.jeon87@...il.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Bongsu Jeon <bongsu.jeon2@...il.com>,
        Krzysztof Opasiak <k.opasiak@...sung.com>,
        linux-nfc@...ts.01.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net-next 1/3] nfc: s3fwrn5: use signed integer for parsing
 GPIO numbers

On Fri, Nov 27, 2020 at 2:06 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On Fri, Nov 27, 2020 at 12:33:37AM +0900, bongsu.jeon2@...il.com wrote:
> > From: Krzysztof Kozlowski <krzk@...nel.org>
> >
> > GPIOs - as returned by of_get_named_gpio() and used by the gpiolib - are
> > signed integers, where negative number indicates error.  The return
> > value of of_get_named_gpio() should not be assigned to an unsigned int
> > because in case of !CONFIG_GPIOLIB such number would be a valid GPIO.
> >
> > Fixes: c04c674fadeb ("nfc: s3fwrn5: Add driver for Samsung S3FWRN5 NFC Chip")
> > Cc: <stable@...r.kernel.org>
> > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
>
> Why do you send my patch?
>

I think that your patch should be applied before refactoring for this driver.
So, I applied your patch to net-next branch and included your patch at
my patch list.
Is this the wrong process?

> Best regards,
> Krzysztof