netdev - Re: [PATCH net] sock: set sk_err to ee

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201127110734.64598288@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Fri, 27 Nov 2020 11:07:34 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Soheil Hassas Yeganeh <soheil@...gle.com>
Cc:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Willem de Bruijn <willemb@...gle.com>,
        Ayush Ranjan <ayushranjan@...gle.com>
Subject: Re: [PATCH net] sock: set sk_err to ee_errno on dequeue from errq

On Thu, 26 Nov 2020 12:28:36 -0500 Soheil Hassas Yeganeh wrote:
> > From: Willem de Bruijn <willemb@...gle.com>
> >
> > When setting sk_err, set it to ee_errno, not ee_origin.
> >
> > Commit f5f99309fa74 ("sock: do not set sk_err in
> > sock_dequeue_err_skb") disabled updating sk_err on errq dequeue,
> > which is correct for most error types (origins):
> >
> >   -       sk->sk_err = err;
> >
> > Commit 38b257938ac6 ("sock: reset sk_err when the error queue is
> > empty") reenabled the behavior for IMCP origins, which do require it:
> >
> >   +       if (icmp_next)
> >   +               sk->sk_err = SKB_EXT_ERR(skb_next)->ee.ee_origin;
> >
> > But read from ee_errno.
> >
> > Fixes: 38b257938ac6 ("sock: reset sk_err when the error queue is empty")
> > Reported-by: Ayush Ranjan <ayushranjan@...gle.com>
> > Signed-off-by: Willem de Bruijn <willemb@...gle.com>  
> 
> Acked-by: Soheil Hassas Yeganeh <soheil@...gle.com>

Applied, thanks!