netdev - Re: [PATCH v4 net-next 3/3] net/sched: sch_frag: add generic packet fragment support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201127143742.1d7a6873@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Fri, 27 Nov 2020 14:37:42 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jamal Hadi Salim <jhs@...atatu.com>
Cc:     Cong Wang <xiyou.wangcong@...il.com>, wenxu <wenxu@...oud.cn>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Vlad Buslov <vladbu@...dia.com>
Subject: Re: [PATCH v4 net-next 3/3] net/sched: sch_frag: add generic packet
 fragment support.

On Thu, 26 Nov 2020 08:26:37 -0500 Jamal Hadi Salim wrote:
> On 2020-11-26 12:03 a.m., Cong Wang wrote:
> > On Wed, Nov 25, 2020 at 11:11 AM Jakub Kicinski <kuba@...nel.org> wrote:  
> >>
> >> On Wed, 25 Nov 2020 12:01:23 +0800 wenxu@...oud.cn wrote:  
> >>> From: wenxu <wenxu@...oud.cn>
> >>>
> >>> Currently kernel tc subsystem can do conntrack in cat_ct. But when several
> >>> fragment packets go through the act_ct, function tcf_ct_handle_fragments
> >>> will defrag the packets to a big one. But the last action will redirect
> >>> mirred to a device which maybe lead the reassembly big packet over the mtu
> >>> of target device.
> >>>
> >>> This patch add support for a xmit hook to mirred, that gets executed before
> >>> xmiting the packet. Then, when act_ct gets loaded, it configs that hook.
> >>> The frag xmit hook maybe reused by other modules.
> >>>
> >>> Signed-off-by: wenxu <wenxu@...oud.cn>  
> >>
> >> LGMT. Cong, Jamal still fine by you guys?  
> > 
> > Yes, I do not look much into detail, but overall it definitely looks good.
> > This is targeting net-next, so it is fine to fix anything we miss later.
> > 
> > Acked-by: Cong Wang <cong.wang@...edance.com>  
> 
> Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

Alright, applied, thanks everyone!