netdev - Re: [PATCH] can: don't count arbitration lose as an error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5f3940f-99e2-95df-7985-0b6ace0b3faf@victronenergy.com>
Date:   Fri, 27 Nov 2020 17:02:03 +0100
From:   Jeroen Hofstee <jhofstee@...tronenergy.com>
To:     Marc Kleine-Budde <mkl@...gutronix.de>, linux-can@...r.kernel.org
Cc:     Oliver Hartkopp <socketcan@...tkopp.net>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>
Subject: Re: [PATCH] can: don't count arbitration lose as an error

Hello Marc,

[...]

>
>
>>   What about one shot mode on the sja1000 cores?
>
>
> That is a good question. I guess it will be counted as error by:
>
>         if (isrc & IRQ_TI) {
>             /* transmission buffer released */
>             if (priv->can.ctrlmode & CAN_CTRLMODE_ONE_SHOT &&
>                 !(status & SR_TCS)) {
>                 stats->tx_errors++;
>                 can_free_echo_skb(dev, 0);
>             } else {
>                 /* transmission complete */
>                 stats->tx_bytes +=
>                     priv->read_reg(priv, SJA1000_FI) & 0xf;
>                 stats->tx_packets++;
>                 can_get_echo_skb(dev, 0);
>             }
>             netif_wake_queue(dev);
>             can_led_event(dev, CAN_LED_EVENT_TX);
>         }
>
>

I just realized this is likely the case. If it wasn't called,
can_free_echo_skb won't be called, causing a memory
leak. I guess someone would have noticed that.

Regards,

Jeroen