netdev - Re: [RESEND PATCH v2] dt-bindings: net: correct interrupt flags in examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201128144912.5d5a9430@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Sat, 28 Nov 2020 14:49:12 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
Cc:     Krzysztof Kozlowski <krzk@...nel.org>, Dan Murphy <dmurphy@...com>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        "David S. Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>
Subject: Re: [RESEND PATCH v2] dt-bindings: net: correct interrupt flags in
 examples

On Fri, 27 Nov 2020 20:35:55 +0100 Marc Kleine-Budde wrote:
> On 11/27/20 5:27 PM, Jakub Kicinski wrote:
> > On Fri, 27 Nov 2020 10:13:01 +0100 Marc Kleine-Budde wrote:  
> >> On 10/26/20 4:36 PM, Krzysztof Kozlowski wrote:  
> >>> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> >>> These are simple defines so they could be used in DTS but they will not
> >>> have the same meaning:
> >>> 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
> >>> 2. GPIO_ACTIVE_LOW  = 1 = IRQ_TYPE_EDGE_RISING
> >>>
> >>> Correct the interrupt flags, assuming the author of the code wanted same
> >>> logical behavior behind the name "ACTIVE_xxx", this is:
> >>>   ACTIVE_LOW  => IRQ_TYPE_LEVEL_LOW
> >>>   ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> >>> Acked-by: Rob Herring <robh@...nel.org>
> >>> Acked-by: Marc Kleine-Budde <mkl@...gutronix.de> # for tcan4x5x.txt    
> >>
> >> Jakub, can you queue this patch for net/master?  
> > 
> > Sure! Are these correct?
> > 
> > Fixes: a1a8b4594f8d ("NFC: pn544: i2c: Add DTS Documentation")
> > Fixes: 6be88670fc59 ("NFC: nxp-nci_i2c: Add I2C support to NXP NCI driver")  
> 
> ACK:

Applied to net and queued for stable, thanks!