netdev - Re: [PATCH net] net: dsa: reference count the host mdb addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201128002717.buvgy3unu6af5ejj@skbuf>
Date:   Sat, 28 Nov 2020 00:27:18 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Tobias Waldekranz <tobias@...dekranz.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>
Subject: Re: [PATCH net] net: dsa: reference count the host mdb addresses

On Sat, Nov 28, 2020 at 12:58:10AM +0100, Tobias Waldekranz wrote:
> That sounds like a good idea. We have run into another issue with the
> MDB that maybe could be worked into this changeset. This is what we have
> observed on 4.19, but from looking at the source it does not look like
> anything has changed with respect to this issue.
>
> The DSA driver handles the addition/removal of router ports by
> enabling/disabling multicast flooding to the port in question. On
> mv88e6xxx at least, this is only part of the solution. It only takes
> care of the unregistered multicast. You also have to iterate through all
> _registered_ groups and add the port to the destination vector.

And this observation is based on what? Based on this paragraph from RFC4541?

2.1.2.  Data Forwarding Rules

   1) Packets with a destination IP address outside 224.0.0.X which are
      not IGMP should be forwarded according to group-based port
      membership tables and must also be forwarded on router ports.

Let me ask you a different question. Why would DSA be in charge of
updating the MDB records, and not the bridge? Or why DSA and not the end
driver? Ignore my patch. I'm just trying to understand what you're
saying. Why precisely DSA, the mid layer? I don't know, this is new
information to me, I'm still digesting it.