netdev - Re: [PATCH net-next] netfilter: bridge: reset skb->pkt_type after NF_INET_POST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201128095929.GI2730@breakpoint.cc>
Date:   Sat, 28 Nov 2020 10:59:29 +0100
From:   Florian Westphal <fw@...len.de>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Florian Westphal <fw@...len.de>,
        Antoine Tenart <atenart@...nel.org>, pablo@...filter.org,
        kadlec@...filter.org, roopa@...dia.com, nikolay@...dia.com,
        netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, sbrivio@...hat.com
Subject: Re: [PATCH net-next] netfilter: bridge: reset skb->pkt_type after
 NF_INET_POST_ROUTING traversal

Jakub Kicinski <kuba@...nel.org> wrote:
> On Mon, 23 Nov 2020 19:32:53 +0100 Florian Westphal wrote:
> > That comment is 18 years old, safe bet noone thought of
> > ipv6-in-tunnel-interface-added-as-bridge-port back then.
> > 
> > Reviewed-by: Florian Westphal <fw@...len.de>
> 
> Sounds like a fix. Probably hard to pin point which commit to blame,
> but this should go to net, not net-next, right?

The commit predates git history, so probably a good idea to add
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

... and apply it to net tree.