netdev - Re: [PATCH v12 1/5] bus: mhi: core: Add helper API to return number of free TREs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201128062946.GL3077@thinkpad>
Date:   Sat, 28 Nov 2020 11:59:46 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     Loic Poulain <loic.poulain@...aro.org>
Cc:     Hemant Kumar <hemantk@...eaurora.org>,
        Bhaumik Bhatt <bbhatt@...eaurora.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Jeffrey Hugo <jhugo@...eaurora.org>,
        Network Development <netdev@...r.kernel.org>,
        skhan@...uxfoundation.org
Subject: Re: [PATCH v12 1/5] bus: mhi: core: Add helper API to return number
 of free TREs

On Wed, Nov 18, 2020 at 10:32:45AM +0100, Loic Poulain wrote:
> On Mon, 16 Nov 2020 at 23:46, Hemant Kumar <hemantk@...eaurora.org> wrote:
> >
> > Introduce mhi_get_free_desc_count() API to return number
> > of TREs available to queue buffer. MHI clients can use this
> > API to know before hand if ring is full without calling queue
> > API.
> >
> > Signed-off-by: Hemant Kumar <hemantk@...eaurora.org>
> > Reviewed-by: Jeffrey Hugo <jhugo@...eaurora.org>
> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> 
> In case this series get new comments to address, I would suggest
> merging that patch in mhi-next separately so that other drivers can
> start benefiting this function (I would like to use it in mhi-net).
> 

Greg doesn't like that. He asked me to pick APIs only when there an in-tree
consumer available.

Thanks,
Mani

> Regards,
> Loic