netdev - Re: [PATCH bpf-next 5/7] selftests/bpf: add tp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201129015934.qlikfg7czp4cc7sf@ast-mbp>
Date:   Sat, 28 Nov 2020 17:59:34 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Andrii Nakryiko <andrii@...nel.org>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org, ast@...com,
        daniel@...earbox.net, kernel-team@...com
Subject: Re: [PATCH bpf-next 5/7] selftests/bpf: add tp_btf CO-RE reloc test
 for modules

On Fri, Nov 20, 2020 at 06:46:14PM -0800, Andrii Nakryiko wrote:
>  
>  SEC("raw_tp/bpf_sidecar_test_read")
> -int BPF_PROG(test_core_module,
> +int BPF_PROG(test_core_module_probed,
>  	     struct task_struct *task,
>  	     struct bpf_sidecar_test_read_ctx *read_ctx)
>  {
> @@ -64,3 +64,33 @@ int BPF_PROG(test_core_module,
>  
>  	return 0;
>  }
> +
> +SEC("tp_btf/bpf_sidecar_test_read")
> +int BPF_PROG(test_core_module_direct,
> +	     struct task_struct *task,
> +	     struct bpf_sidecar_test_read_ctx *read_ctx)

"sidecar" is such an overused name.
I didn't like it earlier, but seeing that it here again and again I couldn't help it.
Could you please pick a different name for kernel module?
It's just a kernel module for testing. Just call it so. No need for fancy name.