netdev - Re: [PATCH 2/2] net: dsa: ksz8795: adjust CPU link to host interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 29 Nov 2020 18:07:22 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Jean Pihet <jean.pihet@...oldbits.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ryan Barnett <ryan.barnett@...kwellcollins.com>,
        Conrad Ratschan <conrad.ratschan@...kwellcollins.com>,
        Hugo Cornelis <hugo.cornelis@...ensium.com>,
        Arnout Vandecappelle <arnout.vandecappelle@...ensium.com>
Subject: Re: [PATCH 2/2] net: dsa: ksz8795: adjust CPU link to host interface

On Sun, Nov 29, 2020 at 11:24:00AM +0100, Jean Pihet wrote:
> Add support for RGMII in 100 and 1000 Mbps.
> 
> Adjust the CPU port based on the host interface settings: interface
> MII type, speed, duplex.

Please could you add some extra information here why this is needed. I
suspect you have back to back PHYs on the CPU port?

> +void ksz8795_adjust_link(struct dsa_switch *ds, int port,
> +						 struct phy_device *phydev)
> +{
> +	struct ksz_device *dev = ds->priv;
> +	struct ksz_port *p = &dev->ports[port];
> +
> +	/* Adjust the link interface mode and speed for the CPU port */
> +	if (port == dev->cpu_port)

dsa_is_cpu_port(ds, port)

		    Andrew