netdev - Re: [PATCH] bpf: remove trailing semicolon in macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4e9c057d-6aa9-e8d1-f84c-1112c509bb52@redhat.com>
Date:   Sun, 29 Nov 2020 09:28:30 -0800
From:   Tom Rix <trix@...hat.com>
To:     Daniel Borkmann <daniel@...earbox.net>, ast@...nel.org,
        andrii@...nel.org, kafai@...com, songliubraving@...com, yhs@...com,
        john.fastabend@...il.com, kpsingh@...omium.org,
        rostedt@...dmis.org, mingo@...hat.com, davem@...emloft.net,
        kuba@...nel.org, hawk@...nel.org
Cc:     netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bpf: remove trailing semicolon in macro definition


On 11/27/20 4:54 PM, Daniel Borkmann wrote:
> On 11/27/20 8:27 PM, trix@...hat.com wrote:
>> From: Tom Rix <trix@...hat.com>
>>
>> The macro use will already have a semicolon.
>>
>> Signed-off-by: Tom Rix <trix@...hat.com>
>> ---
>>   include/trace/events/xdp.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/trace/events/xdp.h b/include/trace/events/xdp.h
>> index cd24e8a59529..65ffedf8386f 100644
>> --- a/include/trace/events/xdp.h
>> +++ b/include/trace/events/xdp.h
>> @@ -146,13 +146,13 @@ DEFINE_EVENT(xdp_redirect_template, xdp_redirect_err,
>>   );
>>     #define _trace_xdp_redirect(dev, xdp, to)        \
>> -     trace_xdp_redirect(dev, xdp, NULL, 0, NULL, to);
>> +     trace_xdp_redirect(dev, xdp, NULL, 0, NULL, to)
>>     #define _trace_xdp_redirect_err(dev, xdp, to, err)    \
>>        trace_xdp_redirect_err(dev, xdp, NULL, err, NULL, to);
>>     #define _trace_xdp_redirect_map(dev, xdp, to, map, index)        \
>> -     trace_xdp_redirect(dev, xdp, to, 0, map, index);
>> +     trace_xdp_redirect(dev, xdp, to, 0, map, index)
>>     #define _trace_xdp_redirect_map_err(dev, xdp, to, map, index, err)    \
>>        trace_xdp_redirect_err(dev, xdp, to, err, map, index);
>>
>
> This looks random, why those but not other locations ?

Those other macros were never used.

Tom

>
> Thanks,
> Daniel
>