netdev - Re: [PATCH 00/10 net-next] net/tipc: fix all kernel-doc and add TIPC networking chapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0d94930d-45c2-f5ef-202e-f3dc2f94c11d@infradead.org>
Date:   Sun, 29 Nov 2020 09:54:01 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Ying Xue <ying.xue@...driver.com>
Cc:     Jon Maloy <jmaloy@...hat.com>, netdev@...r.kernel.org,
        tipc-discussion@...ts.sourceforge.net,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH 00/10 net-next] net/tipc: fix all kernel-doc and add TIPC
 networking chapter

On 11/28/20 11:37 PM, Ying Xue wrote:
> On 11/25/20 12:20 PM, Randy Dunlap wrote:
>>
>> Question: is net/tipc/discover.c, in tipc_disc_delete() kernel-doc,
>> what is the word "duest"?  Should it be changed?
> 
> The "duest" is a typo, and it should be "dest" defined as below:
> struct tipc_discoverer {
>         u32 bearer_id;
>         struct tipc_media_addr dest; ===> "dest"
>         struct net *net;
>         u32 domain;
>         int num_nodes;
>         spinlock_t lock;
>         struct sk_buff *skb;
>         struct timer_list timer;
>         unsigned long timer_intv;
> };
> 

Thanks. I'll take care of this one and your comments
on patch #1.

-- 
~Randy