netdev - Re: [PATCH v4] vdpa: mlx5: fix vdpa/vhost dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b6a1231c-8b81-6c69-3c63-74bf438da866@redhat.com>
Date:   Mon, 30 Nov 2020 10:12:00 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     kernel test robot <lkp@...el.com>, Eli Cohen <eli@...lanox.com>,
        Parav Pandit <parav@...lanox.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        virtualization@...ts.linux-foundation.org,
        Saeed Mahameed <saeedm@...dia.com>,
        Leon Romanovsky <leonro@...dia.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v4] vdpa: mlx5: fix vdpa/vhost dependencies


On 2020/11/29 上午5:39, Randy Dunlap wrote:
> drivers/vdpa/mlx5/ uses vhost_iotlb*() interfaces, so select
> VHOST_IOTLB to make them be built.
>
> However, if VHOST_IOTLB is the only VHOST symbol that is
> set/enabled, the object file still won't be built because
> drivers/Makefile won't descend into drivers/vhost/ to build it,
> so make drivers/Makefile build the needed binary whenever
> VHOST_IOTLB is set, like it does for VHOST_RING.
>
> Fixes these build errors:
> ERROR: modpost: "vhost_iotlb_itree_next" [drivers/vdpa/mlx5/mlx5_vdpa.ko] undefined!
> ERROR: modpost: "vhost_iotlb_itree_first" [drivers/vdpa/mlx5/mlx5_vdpa.ko] undefined!
>
> Fixes: 29064bfdabd5 ("vdpa/mlx5: Add support library for mlx5 VDPA implementation")
> Fixes: aff90770e54c ("vdpa/mlx5: Fix dependency on MLX5_CORE")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Eli Cohen <eli@...lanox.com>
> Cc: Parav Pandit <parav@...lanox.com>
> Cc: "Michael S. Tsirkin" <mst@...hat.com>
> Cc: Jason Wang <jasowang@...hat.com>
> Cc: virtualization@...ts.linux-foundation.org
> Cc: Saeed Mahameed <saeedm@...dia.com>
> Cc: Leon Romanovsky <leonro@...dia.com>
> Cc: netdev@...r.kernel.org
> ---
> v2: change from select to depends on VHOST (Saeed)
> v3: change to depends on VHOST_IOTLB (Jason)
> v4: use select VHOST_IOTLB (Michael); also add to drivers/Makefile
>
>   drivers/Makefile     |    1 +
>   drivers/vdpa/Kconfig |    1 +
>   2 files changed, 2 insertions(+)
>
> --- linux-next-20201127.orig/drivers/vdpa/Kconfig
> +++ linux-next-20201127/drivers/vdpa/Kconfig
> @@ -32,6 +32,7 @@ config IFCVF
>   
>   config MLX5_VDPA
>   	bool
> +	select VHOST_IOTLB
>   	help
>   	  Support library for Mellanox VDPA drivers. Provides code that is
>   	  common for all types of VDPA drivers. The following drivers are planned:
> --- linux-next-20201127.orig/drivers/Makefile
> +++ linux-next-20201127/drivers/Makefile
> @@ -143,6 +143,7 @@ obj-$(CONFIG_OF)		+= of/
>   obj-$(CONFIG_SSB)		+= ssb/
>   obj-$(CONFIG_BCMA)		+= bcma/
>   obj-$(CONFIG_VHOST_RING)	+= vhost/
> +obj-$(CONFIG_VHOST_IOTLB)	+= vhost/
>   obj-$(CONFIG_VHOST)		+= vhost/
>   obj-$(CONFIG_VLYNQ)		+= vlynq/
>   obj-$(CONFIG_GREYBUS)		+= greybus/
>

Acked-by: Jason Wang <jasowang@...hat.com>

Thanks