netdev - Re: [PATCH 3/5] tc: fix compiler warnings in ip6 pedit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zh2yo2zp.fsf@nvidia.com>
Date:   Tue, 1 Dec 2020 00:10:18 +0100
From:   Petr Machata <petrm@...dia.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
CC:     <netdev@...r.kernel.org>, <petrm@...lanox.com>
Subject: Re: [PATCH 3/5] tc: fix compiler warnings in ip6 pedit


Stephen Hemminger <stephen@...workplumber.org> writes:

> Gcc-10 complains about referencing a zero size array.
> This occurs because the array of keys is actually in the following
> structure which is part of the overall selector.
>
> The original code was safe, but better to just use the key
> array directly.
>
> Fixes: 2d9a8dc439ee ("tc: p_ip6: Support pedit of IPv6 dsfield")
> Cc: petrm@...lanox.com
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>

Reviewed-by: Petr Machata <petrm@...dia.com>