netdev - Re: [PATCH] net: flow_offload: remove trailing semicolon in macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d9536d9-b2ba-d3f9-5cf7-56c8dd67bb3e@gmail.com>
Date:   Mon, 30 Nov 2020 09:24:03 +0000
From:   Edward Cree <ecree.xilinx@...il.com>
To:     trix@...hat.com, davem@...emloft.net, kuba@...nel.org,
        wenxu@...oud.cn, pablo@...filter.org, jiri@...lanox.com,
        herbert@...dor.apana.org.au, paulb@...lanox.com,
        john.hurley@...ronome.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: flow_offload: remove trailing semicolon in macro
 definition

On 27/11/2020 19:37, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> The macro use will already have a semicolon.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  net/core/flow_offload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/core/flow_offload.c b/net/core/flow_offload.c
> index d4474c812b64..59ddfd3f3876 100644
> --- a/net/core/flow_offload.c
> +++ b/net/core/flow_offload.c
> @@ -32,7 +32,7 @@ EXPORT_SYMBOL(flow_rule_alloc);
>  	struct flow_dissector *__d = (__m)->dissector;				\
>  										\
>  	(__out)->key = skb_flow_dissector_target(__d, __type, (__m)->key);	\
> -	(__out)->mask = skb_flow_dissector_target(__d, __type, (__m)->mask);	\
> +	(__out)->mask = skb_flow_dissector_target(__d, __type, (__m)->mask)	\
>  Strictly speaking shouldn't this macro have a do {} while (0)
 around it anyway?

-ed