netdev - Re: [PATCH] can: don't count arbitration lose as an error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba9e04b1-1e92-92ef-e4fb-4ae003d78fdc@pengutronix.de>
Date:   Mon, 30 Nov 2020 12:50:26 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Jeroen Hofstee <jhofstee@...tronenergy.com>,
        linux-can@...r.kernel.org
Cc:     Oliver Hartkopp <socketcan@...tkopp.net>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
        "moderated list:ARM/Allwinner sunXi SoC support" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] can: don't count arbitration lose as an error

On 11/27/20 11:30 AM, Marc Kleine-Budde wrote:
> On 11/27/20 10:59 AM, Jeroen Hofstee wrote:
>> Losing arbitration is normal in a CAN-bus network, it means that a
>> higher priority frame is being send and the pending message will be
>> retried later. Hence most driver only increment arbitration_lost, but
>> the sja1000 and sun4i driver also incremeant tx_error, causing errors
>> to be reported on a normal functioning CAN-bus. So stop counting them
>> as errors.
> 
> Sounds plausible.
> 
>> For completeness, the Kvaser USB hybra also increments the tx_error
>> on arbitration lose, but it does so in single shot. Since in that
>> case the message is not retried, that behaviour is kept.
> 
> You mean only in one shot mode? What about one shot mode on the sja1000 cores?
> 
>> Signed-off-by: Jeroen Hofstee <jhofstee@...tronenergy.com>
> 
> I've split this into two patches, and added Fixes: lines, and pushed this for
> now to linux-can/sja1000.

Added to linux-can/testing

Tnx,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)