netdev - Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201130133114.ifjtn366yanj2z3c@mchp-dev-shegelun>
Date:   Mon, 30 Nov 2020 14:31:14 +0100
From:   Steen Hegelund <steen.hegelund@...rochip.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Lars Povlsen <lars.povlsen@...rochip.com>,
        Bjarni Jonasson <bjarni.jonasson@...rochip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Microsemi List <microsemi@...ts.bootlin.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

On 29.11.2020 18:26, Andrew Lunn wrote:
>EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>> +static void sparx5_hw_lock(struct sparx5 *sparx5)
>> +{
>> +     mutex_lock(&sparx5->lock);
>> +}
>> +
>> +static void sparx5_hw_unlock(struct sparx5 *sparx5)
>> +{
>> +     mutex_unlock(&sparx5->lock);
>> +}
>
>Why is this mutex special and gets a wrapper where as the other two
>don't? If there is no reason for the wrapper, please remove it.
>
>       Andrew


Hi Andrew,

There is no need for any special treatment, so I will remove the
wrapper.

BR
Steen


---------------------------------------
Steen Hegelund
steen.hegelund@...rochip.com