netdev - Re: [PATCH] net: bna: remove trailing semicolon in macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 1 Dec 2020 09:25:16 -0800
From:   Tom Rix <trix@...hat.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     rmody@...vell.com, skalluru@...vell.com, davem@...emloft.net,
        GR-Linux-NIC-Dev@...vell.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: bna: remove trailing semicolon in macro definition


On 11/30/20 7:01 PM, Jakub Kicinski wrote:
> On Fri, 27 Nov 2020 08:55:50 -0800 trix@...hat.com wrote:
>> From: Tom Rix <trix@...hat.com>
>>
>> The macro use will already have a semicolon.
>>
>> Signed-off-by: Tom Rix <trix@...hat.com>
>> ---
>>  drivers/net/ethernet/brocade/bna/bna_hw_defs.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/brocade/bna/bna_hw_defs.h b/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
>> index f335b7115c1b..4b19855017d7 100644
>> --- a/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
>> +++ b/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
>> @@ -218,7 +218,7 @@ do {									\
>>  
>>  /* Set the coalescing timer for the given ib */
>>  #define bna_ib_coalescing_timer_set(_i_dbell, _cls_timer)		\
>> -	((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0));
>> +	((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0))
>>  
>>  /* Acks 'events' # of events for a given ib while disabling interrupts */
>>  #define bna_ib_ack_disable_irq(_i_dbell, _events)			\
>> @@ -260,7 +260,7 @@ do {									\
>>  
>>  #define bna_txq_prod_indx_doorbell(_tcb)				\
>>  	(writel(BNA_DOORBELL_Q_PRD_IDX((_tcb)->producer_index), \
>> -		(_tcb)->q_dbell));
>> +		(_tcb)->q_dbell))
>>  
>>  #define bna_rxq_prod_indx_doorbell(_rcb)				\
>>  	(writel(BNA_DOORBELL_Q_PRD_IDX((_rcb)->producer_index), \
> Same story here as Daniel pointed out for the BPF patch.
>
> There are 2 macros right below here which also have a semicolon at the
> end. And these ones are used. So the patch appears to be pretty arbitrary.

I will add the other macros in the next revision.

Sorry,

Tom

>