netdev - Re: [PATCH net v2 0/2] ibmvnic: Bug fixes for queue descriptor processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201130171249.2bc0d7ba@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Mon, 30 Nov 2020 17:12:49 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Thomas Falcon <tlfalcon@...ux.ibm.com>
Cc:     mpe@...erman.id.au, netdev@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, cforno12@...ux.ibm.com,
        ljp@...ux.vnet.ibm.com, ricklind@...ux.ibm.com,
        dnbanerg@...ibm.com, drt@...ux.vnet.ibm.com,
        brking@...ux.vnet.ibm.com, sukadev@...ux.vnet.ibm.com
Subject: Re: [PATCH net v2 0/2] ibmvnic: Bug fixes for queue descriptor
 processing

On Mon, 30 Nov 2020 13:07:22 -0600 Thomas Falcon wrote:
> This series resolves a few issues in the ibmvnic driver's
> RX buffer and TX completion processing. The first patch
> includes memory barriers to synchronize queue descriptor
> reads. The second patch fixes a memory leak that could
> occur if the device returns a TX completion with an error
> code in the descriptor, in which case the respective socket
> buffer and other relevant data structures may not be freed
> or updated properly.
> 
> v2: Provide more detailed comments explaining specifically what
>     reads are being ordered, suggested by Michael Ellerman

The commit hashes on fixes tags need to be at least 12 characters long,
please fix and repost.