lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 30 Nov 2020 18:22:01 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     George Cherian <george.cherian@...vell.com>
Cc:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <davem@...emloft.net>, <sgoutham@...vell.com>,
        <lcherian@...vell.com>, <gakula@...vell.com>,
        <masahiroy@...nel.org>, <willemdebruijn.kernel@...il.com>,
        <saeed@...nel.org>, <jiri@...nulli.us>
Subject: Re: [PATCHv5 net-next 1/3] octeontx2-af: Add devlink suppoort to af
 driver

On Thu, 26 Nov 2020 19:32:49 +0530 George Cherian wrote:
> Add devlink support to AF driver. Basic devlink support is added.
> Currently info_get is the only supported devlink ops.
> 
> devlink ouptput looks like this
>  # devlink dev
>  pci/0002:01:00.0
>  # devlink dev info
>  pci/0002:01:00.0:
>   driver octeontx2-af
>   versions:
>       fixed:
>         mbox version: 9

You need to document what this version is exactly. See how other
drivers document things. It's also strongly preferred to use one 
of the existing identifiers if any one is matching the semantics.

Fixed versions are for hardware versions, like ASIC rev or PCB board
id or version.

Your thing looks like a SW message format. It's not even FW.
It doesn't belong in devlink at all.

Powered by blists - more mailing lists