netdev - Re: [PATCH net] cxgb3: fix error return code in t3_sge_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Dec 2020 17:14:26 +0530
From:   Raju Rangoju <rajur@...lsio.com>
To:     Zhang Changzhong <zhangchangzhong@...wei.com>
Cc:     davem@...emloft.net, kuba@...nel.org, divy@...lsio.com,
        jgarzik@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] cxgb3: fix error return code in t3_sge_alloc_qset()

On Wednesday, December 12/02/20, 2020 at 17:56:05 +0800, Zhang Changzhong wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
> 
> Fixes: b1fb1f280d09 ("cxgb3 - Fix dma mapping error path")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>
> ---

Acked-by: Raju Rangoju <rajur@...lsio.com>

>  drivers/net/ethernet/chelsio/cxgb3/sge.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c
> index e18e9ce..1cc3c51 100644
> --- a/drivers/net/ethernet/chelsio/cxgb3/sge.c
> +++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c
> @@ -3175,6 +3175,7 @@ int t3_sge_alloc_qset(struct adapter *adapter, unsigned int id, int nports,
>  			  GFP_KERNEL | __GFP_COMP);
>  	if (!avail) {
>  		CH_ALERT(adapter, "free list queue 0 initialization failed\n");
> +		ret = -ENOMEM;
>  		goto err;
>  	}
>  	if (avail < q->fl[0].size)
> -- 
> 2.9.5
>