netdev - Re: [MPTCP] Re: [PATCH net-next v2] mptcp: be careful on MPTCP-level ack.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d40955d2d33dd36f8bc38067868c19dd8cb5173.camel@redhat.com>
Date:   Wed, 02 Dec 2020 18:08:11 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Eric Dumazet <eric.dumazet@...il.com>, netdev@...r.kernel.org
Cc:     Jakub Kicinski <kuba@...nel.org>, mptcp@...ts.01.org
Subject: Re: [MPTCP] Re: [PATCH net-next v2] mptcp: be careful on
 MPTCP-level ack.

On Wed, 2020-12-02 at 17:51 +0100, Paolo Abeni wrote:
> On Wed, 2020-12-02 at 17:45 +0100, Eric Dumazet wrote:
> > Packetdrill recvmsg syntax would be something like
> > 
> >    +0	recvmsg(3, {msg_name(...)=...,
> > 		    msg_iov(1)=[{..., 0}],
> > 		    msg_flags=0
> > 		    }, 0) = 0
> 
> Thank you very much for all the effort!
> 
> Yes, with recvmsg() the packet drill hangs. I agree your proposed fix
> is correct.
> 
> I can test it explicitly later today.

The proposed fix passes successfully the pktdrill test and there are no
regressions in the other self-tests.

Feel free to add:

Tested-by: Paolo Abeni <pabeni@...hat.com>

thanks!

Paolo