netdev - RE: [PATCH] net: phy: adin: add signal mean square error registers to phy-stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY4PR03MB2966A933B982841E1250EBE0F9F20@CY4PR03MB2966.namprd03.prod.outlook.com>
Date:   Thu, 3 Dec 2020 14:33:45 +0000
From:   "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "Redmond, Catherine" <Catherine.Redmond@...log.com>,
        "Murray, Brian" <Brian.Murray@...log.com>,
        "Baylov, Danail" <Danail.Baylov@...log.com>,
        "OBrien, Maurice" <Maurice.OBrien@...log.com>
Subject: RE: [PATCH] net: phy: adin: add signal mean square error registers to
 phy-stats



> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Thursday, December 3, 2020 4:16 PM
> To: Ardelean, Alexandru <alexandru.Ardelean@...log.com>
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org;
> hkallweit1@...il.com; linux@...linux.org.uk; davem@...emloft.net;
> kuba@...nel.org; Redmond, Catherine <Catherine.Redmond@...log.com>;
> Murray, Brian <Brian.Murray@...log.com>; Baylov, Danail
> <Danail.Baylov@...log.com>; OBrien, Maurice
> <Maurice.OBrien@...log.com>
> Subject: Re: [PATCH] net: phy: adin: add signal mean square error registers to
> phy-stats
> 
> On Thu, Dec 03, 2020 at 10:07:19AM +0200, Alexandru Ardelean wrote:
> > When the link is up on the ADIN1300/ADIN1200, the signal quality on
> > each pair is indicated in the mean square error register for each pair
> > (MSE_A, MSE_B, MSE_C, and MSE_D registers, Address 0x8402 to Address
> > 0x8405, Bits[7:0]).
> >
> > These values can be useful for some industrial applications.
> >
> > This change implements support for these registers using the PHY
> > statistics mechanism.
> 
> There was a discussion about values like these before. If i remember correctly, it
> was for a BroadReach PHY. I thought we decided to add them to the link state
> information?
> 

Oh, this is new.
I've had this MSE patch lying around in a branch since last year sometime.
Wasn't sure whether to put it in the phy-stats.

> Ah, found it.
> 
> commit 68ff5e14759e7ac1aac7bc75ac5b935e390fa2b3
> Author: Oleksij Rempel <linux@...pel-privat.de>
> Date:   Wed May 20 08:29:15 2020 +0200
> 
>     net: phy: tja11xx: add SQI support
> 
> and
> 
> ommit 8066021915924f58ed338bf38208215f5a7355f6
> Author: Oleksij Rempel <linux@...pel-privat.de>
> Date:   Wed May 20 08:29:14 2020 +0200
> 
>     ethtool: provide UAPI for PHY Signal Quality Index (SQI)
> 
> Can you convert your MSE into SQI?

I'll take a look and try to understand the SQI spec.
It's neat that there's a common place where to put this.

Thanks
Alex

> 
>     Andrew