lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 3 Dec 2020 16:36:26 +0100
From:   Christian Eggers <>
To:     Richard Cochran <>
CC:     Vladimir Oltean <>,
        Jakub Kicinski <>, Andrew Lunn <>,
        Rob Herring <>,
        "Vivien Didelot" <>,
        "David S . Miller" <>,
        Kurt Kanzenbach <>,
        George McCollister <>,
        Marek Vasut <>,
        Helmut Grohne <>,
        Paul Barker <>,
        "Codrin Ciubotariu" <>,
        Tristram Ha <>,
        Woojung Huh <>,
        Microchip Linux Driver Support <>,
        <>, <>,
Subject: Re: [PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support

On Thursday, 3 December 2020, 15:12:55 CET, Richard Cochran wrote:
> On Thu, Dec 03, 2020 at 11:21:17AM +0100, Christian Eggers wrote:
> > The KSZ9563 has a Trigger Output Unit (TOU) which can be used to
> > generate periodic signals.
> > 
> > The pulse length can be altered via a device attribute.
> Device tree is the wrong place for that.
I meant a device specfic sysfs attribute.

But this is not true anymore, as I moved the sysfs attribute to a later 
patch (not submitted yet).

> Aren't you using PTP_PEROUT_DUTY_CYCLE anyhow?
I also use PTP_PEROUT_DUTY_CYCLE. But this cannot be set via a shell
script. The existing "period" sysfs attribute doesn't allow to set
the pulse length, so I added a device specific attribute for this.

Should ptp_sysfs be extended with a "pulse" attribute with calls
enable() with only PTP_PEROUT_DUTY_CYCLE set?

> Thanks,
> Richard

Powered by blists - more mailing lists