lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 3 Dec 2020 10:55:47 -0800
From:   Jakub Kicinski <>
To:     Dan Carpenter <>
Cc:     Ayush Sawal <>,
        Atul Gupta <>,
        Vinay Kumar Yadav <>,
        Rohit Maheshwari <>,
        "David S. Miller" <>,
        Herbert Xu <>,,
Subject: Re: [PATCH net] chelsio/chtls: fix a double free in chtls_setkey()

On Thu, 3 Dec 2020 11:44:31 +0300 Dan Carpenter wrote:
> The "skb" is freed by the transmit code in cxgb4_ofld_send() and we
> shouldn't use it again.  But in the current code, if we hit an error
> later on in the function then the clean up code will call kfree_skb(skb)
> and so it causes a double free.
> Set the "skb" to NULL and that makes the kfree_skb() a no-op.
> Fixes: d25f2f71f653 ("crypto: chtls - Program the TLS session Key")
> Signed-off-by: Dan Carpenter <>

Applied, thanks!

Powered by blists - more mailing lists