netdev - Re: [PATCH net-next v4] devlink: Add devlink port documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b15782d6-8156-5468-4b05-cdc5246d789b@infradead.org>
Date:   Thu, 3 Dec 2020 12:31:21 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Parav Pandit <parav@...dia.com>, netdev@...r.kernel.org,
        davem@...emloft.net, kuba@...nel.org
Cc:     jacob.e.keller@...el.com, Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net-next v4] devlink: Add devlink port documentation

Hi--

On 12/3/20 10:02 AM, Parav Pandit wrote:
> Added documentation for devlink port and port function related commands.
> 
> Signed-off-by: Parav Pandit <parav@...dia.com>
> Reviewed-by: Jiri Pirko <jiri@...dia.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> ---
> Changelog:
> v3->v4:
>  - changed 'exist' to 'exists'
>  - added 'an' eswitch
>  - changed 'can have one' to 'consists of'
>  - changed 'who intents' to 'that intends'
>  - removed unnecessary comma
>  - rewrote description for the example diagram
>  - changed 'controller consist of' to 'controller consists of'
> v2->v3:
>  - rephrased many lines
>  - first paragraph now describe devlink port
>  - instead of saying PCI device/function, using PCI function every
>    where
>  - changed 'physical link layer' to 'link layer'
>  - made devlink port type description more clear
>  - made devlink port flavour description more clear
>  - moved devlink port type table after port flavour
>  - added description for the example diagram
>  - describe CPU port that its linked to DSA
>  - made devlink port description for eswitch port more clear
> v1->v2:
>  - Removed duplicate table entries for DEVLINK_PORT_FLAVOUR_VIRTUAL.
>  - replaced 'consist of' to 'consisting'
>  - changed 'can be' to 'can be of'
> ---
>  .../networking/devlink/devlink-port.rst       | 111 ++++++++++++++++++
>  Documentation/networking/devlink/index.rst    |   1 +
>  2 files changed, 112 insertions(+)
>  create mode 100644 Documentation/networking/devlink/devlink-port.rst
> 
> diff --git a/Documentation/networking/devlink/devlink-port.rst b/Documentation/networking/devlink/devlink-port.rst
> new file mode 100644
> index 000000000000..ac18cb8041dc
> --- /dev/null
> +++ b/Documentation/networking/devlink/devlink-port.rst
> @@ -0,0 +1,111 @@

I find that this doc is now readable.  :)

Other people can comment on the technical details.

thanks.

-- 
~Randy
Acked-by: Randy Dunlap <rdunlap@...radead.org>