netdev - Re: net: macb: fail when there's no PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201203211702.GK2333853@lunn.ch>
Date:   Thu, 3 Dec 2020 22:17:02 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Grant Edwards <grant.b.edwards@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: net: macb: fail when there's no PHY

On Thu, Dec 03, 2020 at 03:07:58PM -0000, Grant Edwards wrote:
> On 2020-12-03, Andrew Lunn <andrew@...n.ch> wrote:
> >> So I can avoid my local hack to macb_main.c by doing a doing a local
> >> hack to macb_main.c?
> >
> > User space drivers were never supported in any meaningful way. The
> > IOCTL call is basically there for mii-tool, and nothing much more.
> 
> I probably wouldn't call a single ioctl() to check the link status a
> user-space-driver, but I guess that's what it is. If it's good enough
> for the mii-tool, it's good enough for me.
> 
> > The way to avoid your local hack is to move your drivers into the
> > kernel, along side all the other drivers for devices on MDIO busses.
> 
> I don't think I can justify the additional effort to devlope and
> maintain a custom kern-space driver.

Why custom? You should contribute it.

> >> Was there some other way I should have done this with a 5.4 kernel
> >> that I was unable to discover?

Ah, i missed you are using 5.4. You should probably jump to 5.10. There
have been quite a few changes in this area in the macb driver.
> 
> BTW Andrew, we're still shipping plenty of product that running
> eCos. :)

Cool. There is still a space for such an RTOS, linux has not yet taken
over the world everywhere.

     Andrew