netdev - Re: [PATCH iproute2-next] Only compile mnl_utils when HAVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b6c07397-9799-e9f4-23c7-e1954ee701b5@gmail.com>
Date:   Thu, 3 Dec 2020 15:39:49 -0700
From:   David Ahern <dsahern@...il.com>
To:     Petr Machata <me@...chata.org>, David Ahern <dsahern@...nel.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] Only compile mnl_utils when HAVE_LIBMNL is
 defined

On 12/3/20 2:45 PM, Petr Machata wrote:
> 
> David Ahern <dsahern@...nel.org> writes:
> 
>> diff --git a/lib/Makefile b/lib/Makefile
>> index e37585c6..603ea83e 100644
>> --- a/lib/Makefile
>> +++ b/lib/Makefile
>> @@ -13,7 +13,10 @@ UTILOBJ += bpf_libbpf.o
>>  endif
>>  endif
>>  
>> -NLOBJ=libgenl.o libnetlink.o mnl_utils.o
>> +NLOBJ=libgenl.o libnetlink.o
>> +ifeq ($(HAVE_LIBMNL),y)
> 
> This should test HAVE_MNL, not HAVE_LIBMNL.
> 

d'oh. thanks for catching that.