netdev - RE: [PATCH v5 bpf-next 01/14] bpf: fix bpf_put_raw_tracepoint()'s use of __module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5fc86b43b2006_1123e2084c@john-XPS-13-9370.notmuch>
Date:   Wed, 02 Dec 2020 20:36:19 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Andrii Nakryiko <andrii@...nel.org>, bpf@...r.kernel.org,
        netdev@...r.kernel.org, ast@...com, daniel@...earbox.net
Cc:     andrii@...nel.org, kernel-team@...com,
        Martin KaFai Lau <kafai@...com>
Subject: RE: [PATCH v5 bpf-next 01/14] bpf: fix bpf_put_raw_tracepoint()'s use
 of __module_address()

Andrii Nakryiko wrote:
> __module_address() needs to be called with preemption disabled or with
> module_mutex taken. preempt_disable() is enough for read-only uses, which is
> what this fix does. Also, module_put() does internal check for NULL, so drop
> it as well.
> 
> Fixes: a38d1107f937 ("bpf: support raw tracepoints in modules")
> Acked-by: Martin KaFai Lau <kafai@...com>
> Signed-off-by: Andrii Nakryiko <andrii@...nel.org>
> ---

Acked-by: John Fastabend <john.fastabend@...il.com>