netdev - Re: [PATCH v5 bpf-next 09/14] bpf: remove hard-coded btf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 3 Dec 2020 14:32:47 +0800
From:   kernel test robot <lkp@...el.com>
To:     Andrii Nakryiko <andrii@...nel.org>, bpf@...r.kernel.org,
        netdev@...r.kernel.org, ast@...com, daniel@...earbox.net
Cc:     kbuild-all@...ts.01.org, andrii@...nel.org, kernel-team@...com
Subject: Re: [PATCH v5 bpf-next 09/14] bpf: remove hard-coded btf_vmlinux
 assumption from BPF verifier

Hi Andrii,

I love your patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Andrii-Nakryiko/Support-BTF-powered-BPF-tracing-programs-for-kernel-modules/20201203-115515
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: i386-randconfig-s002-20201203 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-179-ga00755aa-dirty
        # https://github.com/0day-ci/linux/commit/c0eabf99f8312c12d4c210628360d28bbf915a91
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andrii-Nakryiko/Support-BTF-powered-BPF-tracing-programs-for-kernel-modules/20201203-115515
        git checkout c0eabf99f8312c12d4c210628360d28bbf915a91
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   ld: kernel/bpf/core.o: in function `bpf_prog_free':
>> kernel/bpf/core.c:2155: undefined reference to `btf_put'

vim +2155 kernel/bpf/core.c

  2146	
  2147	/* Free internal BPF program */
  2148	void bpf_prog_free(struct bpf_prog *fp)
  2149	{
  2150		struct bpf_prog_aux *aux = fp->aux;
  2151	
  2152		if (aux->dst_prog)
  2153			bpf_prog_put(aux->dst_prog);
  2154		if (aux->attach_btf)
> 2155			btf_put(aux->attach_btf);
  2156		INIT_WORK(&aux->work, bpf_prog_free_deferred);
  2157		schedule_work(&aux->work);
  2158	}
  2159	EXPORT_SYMBOL_GPL(bpf_prog_free);
  2160	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (29583 bytes)