netdev - Re: [PATCH] vhost scsi: fix error return code in vhost_scsi_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c6e01d0-9329-862c-6480-fbb91a8910cf@oracle.com>
Date:   Fri, 4 Dec 2020 10:12:07 -0600
From:   Mike Christie <michael.christie@...cle.com>
To:     Zhang Changzhong <zhangchangzhong@...wei.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Stefan Hajnoczi <stefanha@...hat.com>,
        Maurizio Lombardi <mlombard@...hat.com>
Cc:     virtualization@...ts.linux-foundation.org, kvm@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vhost scsi: fix error return code in
 vhost_scsi_set_endpoint()

On 12/4/20 2:43 AM, Zhang Changzhong wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
> 
> Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>
> ---
>   drivers/vhost/scsi.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
> index 6ff8a5096..4ce9f00 100644
> --- a/drivers/vhost/scsi.c
> +++ b/drivers/vhost/scsi.c
> @@ -1643,7 +1643,8 @@ vhost_scsi_set_endpoint(struct vhost_scsi *vs,
>   			if (!vhost_vq_is_setup(vq))
>   				continue;
>   
> -			if (vhost_scsi_setup_vq_cmds(vq, vq->num))
> +			ret = vhost_scsi_setup_vq_cmds(vq, vq->num);
> +			if (ret)
>   				goto destroy_vq_cmds;
>   		}
>   
> 

Reviewed-by: Mike Christie <michael.christie@...cle.com>