netdev - Re: [PATCH net] net/sched: fq_pie: initialize timer earlier in fq_pie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201204141732.6bd0bdca@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Fri, 4 Dec 2020 14:17:32 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Davide Caratti <dcaratti@...hat.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Mohit Bhasi <mohitbhasi1998@...il.com>,
        Leslie Monis <lesliemonis@...il.com>
Subject: Re: [PATCH net] net/sched: fq_pie: initialize timer earlier in
 fq_pie_init()

On Fri, 4 Dec 2020 10:35:07 -0800 Cong Wang wrote:
> On Thu, Dec 3, 2020 at 10:41 AM Davide Caratti <dcaratti@...hat.com> wrote:
> >
> > with the following tdc testcase:
> >
> >  83be: (qdisc, fq_pie) Create FQ-PIE with invalid number of flows
> >
> > as fq_pie_init() fails, fq_pie_destroy() is called to clean up. Since the
> > timer is not yet initialized, it's possible to observe a splat like this:  
> ...
> > fix it moving timer_setup() before any failure, like it was done on 'red'
> > with former commit 608b4adab178 ("net_sched: initialize timer earlier in
> > red_init()").
> >
> > Fixes: ec97ecf1ebe4 ("net: sched: add Flow Queue PIE packet scheduler")
> > Signed-off-by: Davide Caratti <dcaratti@...hat.com>  
> 
> Reviewed-by: Cong Wang <cong.wang@...edance.com>

Applied, thanks!