netdev - Re: [PATCH net] vrf: packets with lladdr src needs dst at input with orig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201204153748.00715355@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Fri, 4 Dec 2020 15:37:48 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     David Ahern <dsahern@...il.com>
Cc:     Stephen Suryaputra <ssuryaextr@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net] vrf: packets with lladdr src needs dst at input
 with orig_iif when needs strict

On Fri, 4 Dec 2020 09:32:04 -0700 David Ahern wrote:
> On 12/3/20 8:06 PM, Stephen Suryaputra wrote:
> > Depending on the order of the routes to fe80::/64 are installed on the
> > VRF table, the NS for the source link-local address of the originator
> > might be sent to the wrong interface.
> > 
> > This patch ensures that packets with link-local addr source is doing a
> > lookup with the orig_iif when the destination addr indicates that it
> > is strict.
> > 
> > Add the reproducer as a use case in self test script fcnal-test.sh.
> > 
> > Signed-off-by: Stephen Suryaputra <ssuryaextr@...il.com>
> > ---
> >  drivers/net/vrf.c                         | 10 ++-
> >  tools/testing/selftests/net/fcnal-test.sh | 95 +++++++++++++++++++++++
> >  2 files changed, 103 insertions(+), 2 deletions(-)
> 
> Reviewed-by: David Ahern <dsahern@...nel.org>

Should I put something like:

Fixes: b4869aa2f881 ("net: vrf: ipv6 support for local traffic to local addresses")

on this?