netdev - Re: [PATCH net v1] net: dsa: ksz8795: use correct number of physical ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201204234321.GJ2400258@lunn.ch>
Date:   Sat, 5 Dec 2020 00:43:21 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Sven Van Asbroeck <thesven73@...il.com>,
        Woojung Huh <woojung.huh@...rochip.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        David S Miller <davem@...emloft.net>,
        Marek Vasut <marex@...x.de>,
        Tristram Ha <Tristram.Ha@...rochip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v1] net: dsa: ksz8795: use correct number of physical
 ports

On Fri, Dec 04, 2020 at 03:24:56PM -0800, Jakub Kicinski wrote:
> On Thu,  3 Dec 2020 16:46:45 -0500 Sven Van Asbroeck wrote:
> > From: Sven Van Asbroeck <thesven73@...il.com>
> > 
> > The ksz8795 has five physical ports, but the driver assumes
> > it has only four. This prevents the driver from working correctly.
> > 
> > Fix by indicating the correct number of physical ports.
> > 
> > Fixes: e66f840c08a23 ("net: dsa: ksz: Add Microchip KSZ8795 DSA driver")
> > Tested-by: Sven Van Asbroeck <thesven73@...il.com> # ksz8795
> > Signed-off-by: Sven Van Asbroeck <thesven73@...il.com>
> 
> All the port counts here are -1 compared to datasheets, so I'm assuming
> the are not supposed to include the host facing port or something?
> 
> Can you describe the exact problem you're trying to solve?
> 
> DSA devices are not supposed to have a netdev for the host facing port
> on the switch (sorry for stating the obvious).

Hi Jakub

It is the DSA core layer which takes care of that creating/not
creating netdevs. The switch should declare all the ports it has.

There has been issues with the ksz collection of drivers having
different meanings for port_cnt. There recently was some changes in
this area, maybe it broke something?

     Andrew