lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 4 Dec 2020 02:57:36 +0000 From: Pkshih <pkshih@...ltek.com> To: "tony0620emma@...il.com" <tony0620emma@...il.com>, "colin.king@...onical.com" <colin.king@...onical.com>, DeanKu <ku920601@...ltek.com>, "kuba@...nel.org" <kuba@...nel.org>, "kvalo@...eaurora.org" <kvalo@...eaurora.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org> CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org> Subject: Re: [PATCH][next] rtw88: coex: fix missing unitialization of variable 'interval' On Thu, 2020-12-03 at 17:51 +0000, Colin King wrote: > From: Colin Ian King <colin.king@...onical.com> > > Currently the variable 'interval' is not initialized and is only set > to 1 when oex_stat->bt_418_hid_existi is true. Fix this by inintializing > variable interval to 0 (which I'm assuming is the intended default). > > Addresses-Coverity: ("Uninitalized scalar variable") > Fixes: 5b2e9a35e456 ("rtw88: coex: add feature to enhance HID coexistence > performance") > Signed-off-by: Colin Ian King <colin.king@...onical.com> Thanks for your fix. Acked-by: Ping-Ke Shih <pkshih@...ltek.com> > --- > drivers/net/wireless/realtek/rtw88/coex.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtw88/coex.c > b/drivers/net/wireless/realtek/rtw88/coex.c > index c704c6885a18..24530cafcba7 100644 > --- a/drivers/net/wireless/realtek/rtw88/coex.c > +++ b/drivers/net/wireless/realtek/rtw88/coex.c > @@ -2051,7 +2051,7 @@ static void rtw_coex_action_bt_a2dp_hid(struct rtw_dev > *rtwdev) > struct rtw_coex_dm *coex_dm = &coex->dm; > struct rtw_efuse *efuse = &rtwdev->efuse; > struct rtw_chip_info *chip = rtwdev->chip; > - u8 table_case, tdma_case, interval; > + u8 table_case, tdma_case, interval = 0; > u32 slot_type = 0; > bool is_toggle_table = false; > > -- > 2.29.2 > > > ------Please consider the environment before printing this e-mail.
Powered by blists - more mailing lists