lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 04 Dec 2020 10:39:42 +0100 From: Toke Høiland-Jørgensen <toke@...hat.com> To: Jakub Kicinski <kuba@...nel.org> Cc: "David S. Miller" <davem@...emloft.net>, Daniel Borkmann <daniel@...earbox.net>, Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko <andriin@...com>, Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...omium.org>, Jesper Dangaard Brouer <hawk@...nel.org>, "Michael S. Tsirkin" <mst@...hat.com>, Romain Perier <romain.perier@...il.com>, Allen Pais <apais@...ux.microsoft.com>, Grygorii Strashko <grygorii.strashko@...com>, Simon Horman <simon.horman@...ronome.com>, "Gustavo A. R. Silva" <gustavoars@...nel.org>, Lorenzo Bianconi <lorenzo@...nel.org>, Wei Yongjun <weiyongjun1@...wei.com>, Jiri Benc <jbenc@...hat.com>, oss-drivers@...ronome.com, linux-omap@...r.kernel.org, netdev@...r.kernel.org, bpf@...r.kernel.org Subject: Re: [PATCH bpf 3/7] netdevsim: Add debugfs toggle to reject BPF programs in verifier Jakub Kicinski <kuba@...nel.org> writes: > On Thu, 03 Dec 2020 22:35:20 +0100 Toke Høiland-Jørgensen wrote: >> diff --git a/drivers/net/netdevsim/netdevsim.h b/drivers/net/netdevsim/netdevsim.h >> index 827fc80f50a0..d1d329af3e61 100644 >> --- a/drivers/net/netdevsim/netdevsim.h >> +++ b/drivers/net/netdevsim/netdevsim.h >> @@ -190,6 +190,7 @@ struct nsim_dev { >> struct bpf_offload_dev *bpf_dev; >> bool bpf_bind_accept; >> u32 bpf_bind_verifier_delay; >> + bool bpf_bind_verifier_accept; >> struct dentry *ddir_bpf_bound_progs; > > nit: if you respin please reorder the bpf_bind_verifier_* fields so > that the structure packs better. Ah, good point, will do! > Acked-by: Jakub Kicinski <kuba@...nel.org> > > Thanks for fixing this test! You're welcome :) I'll see if I can't get our CI people to also run it regularly so we can avoid it regressing again... -Toke
Powered by blists - more mailing lists