lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 5 Dec 2020 12:48:59 -0800 From: Jakub Kicinski <kuba@...nel.org> To: Rasmus Villemoes <rasmus.villemoes@...vas.dk> Cc: Li Yang <leoyang.li@....com>, "David S. Miller" <davem@...emloft.net>, Zhao Qiang <qiang.zhao@....com>, Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 11/20] ethernet: ucc_geth: fix use-after-free in ucc_geth_remove() On Sat, 5 Dec 2020 20:17:34 +0100 Rasmus Villemoes wrote: > - unregister_netdev(dev); > - free_netdev(dev); > ucc_geth_memclean(ugeth); > if (of_phy_is_fixed_link(np)) > of_phy_deregister_fixed_link(np); > of_node_put(ugeth->ug_info->tbi_node); > of_node_put(ugeth->ug_info->phy_node); > + unregister_netdev(dev); > + free_netdev(dev); Are you sure you want to move the unregister_netdev() as well as the free?
Powered by blists - more mailing lists