netdev - Re: [PATCH 1/7] net: 8021q: remove unneeded MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201204160924.2e170514@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Fri, 4 Dec 2020 16:09:24 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>
Cc:     linux-kernel@...r.kernel.org, davem@...emloft.net,
        mareklindner@...mailbox.ch, sw@...onwunderlich.de, a@...table.cc,
        sven@...fation.org, marcel@...tmann.org, johan.hedberg@...il.com,
        roopa@...dia.com, nikolay@...dia.com, edumazet@...gle.com,
        kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, jmaloy@...hat.com,
        ying.xue@...driver.com, kafai@...com, songliubraving@...com,
        yhs@...com, john.fastabend@...il.com, kpsingh@...omium.org,
        netdev@...r.kernel.org, linux-bluetooth@...r.kernel.org,
        tipc-discussion@...ts.sourceforge.net,
        linux-hyperv@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage

On Wed,  2 Dec 2020 13:49:53 +0100 Enrico Weigelt, metux IT consult
wrote:
> Remove MODULE_VERSION(), as it isn't needed at all: the only version
> making sense is the kernel version.
> 
> Signed-off-by: Enrico Weigelt, metux IT consult <info@...ux.net>

Thanks for the patches. Please drop the "metux IT consult" from the
addresses. The from space is supposed to be for your name.

> diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
> index f292e0267bb9..683e9e825b9e 100644
> --- a/net/8021q/vlan.c
> +++ b/net/8021q/vlan.c
> @@ -36,15 +36,10 @@
>  #include "vlan.h"
>  #include "vlanproc.h"
>  
> -#define DRV_VERSION "1.8"
> -
>  /* Global VLAN variables */
>  
>  unsigned int vlan_net_id __read_mostly;
>  
> -const char vlan_fullname[] = "802.1Q VLAN Support";
> -const char vlan_version[] = DRV_VERSION;

This patches does not build. Please redo it more carefully.

You'll need to fix and resend the entire series. When you do so please
provide a cover letter, even if it only contains a couple of sentences
and separate the patches for bluetooth and batman-adv out as stand
alone patches, so the respective maintainers can pick them up.