netdev - Re: [PATCH net-next 3/6] net: add sysctl for enabling RFC 8335 PROBE messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <322132d8-7971-da3a-0a9e-2df99c0ea5c4@gmail.com>
Date:   Fri, 4 Dec 2020 22:49:29 -0700
From:   David Ahern <dsahern@...il.com>
To:     Andreas Roeseler <andreas.a.roeseler@...il.com>,
        davem@...emloft.net, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        kuba@...nel.org
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/6] net: add sysctl for enabling RFC 8335 PROBE
 messages

On 12/3/20 8:16 PM, Andreas Roeseler wrote:
> Section 8 of RFC 8335 specifies potential security concerns of
> responding to PROBE requests, and states that nodes that support PROBE
> functionality MUST be able to enable/disable responses and it is
> disabled by default. 
> 
> Add sysctl to enable responses to PROBE messages. 
> 
> Signed-off-by: Andreas Roeseler <andreas.a.roeseler@...il.com>
> ---
>  include/net/netns/ipv4.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/net/netns/ipv4.h b/include/net/netns/ipv4.h
> index 8e4fcac4df72..1d9b74228f3e 100644
> --- a/include/net/netns/ipv4.h
> +++ b/include/net/netns/ipv4.h
> @@ -85,6 +85,7 @@ struct netns_ipv4 {
>  #endif
>  
>  	int sysctl_icmp_echo_ignore_all;
> +	int sysctl_icmp_echo_enable_probe;
>  	int sysctl_icmp_echo_ignore_broadcasts;
>  	int sysctl_icmp_ignore_bogus_error_responses;
>  	int sysctl_icmp_ratelimit;
> 

this can be folded into patch 4; no need for a standalone patch here.