lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 5 Dec 2020 16:53:06 +0100 From: Greg KH <greg@...ah.com> To: Vladimir Oltean <olteanv@...il.com> Cc: "Enrico Weigelt, metux IT consult" <info@...ux.net>, linux-kernel@...r.kernel.org, davem@...emloft.net, kuba@...nel.org, mareklindner@...mailbox.ch, sw@...onwunderlich.de, a@...table.cc, sven@...fation.org, marcel@...tmann.org, johan.hedberg@...il.com, roopa@...dia.com, nikolay@...dia.com, edumazet@...gle.com, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, jmaloy@...hat.com, ying.xue@...driver.com, kafai@...com, songliubraving@...com, yhs@...com, john.fastabend@...il.com, kpsingh@...omium.org, netdev@...r.kernel.org, linux-bluetooth@...r.kernel.org, tipc-discussion@...ts.sourceforge.net, linux-hyperv@...r.kernel.org, bpf@...r.kernel.org Subject: Re: [PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage On Sat, Dec 05, 2020 at 01:20:18PM +0200, Vladimir Oltean wrote: > On Wed, Dec 02, 2020 at 01:49:53PM +0100, Enrico Weigelt, metux IT consult wrote: > > Remove MODULE_VERSION(), as it isn't needed at all: the only version > > making sense is the kernel version. > > > > Signed-off-by: Enrico Weigelt, metux IT consult <info@...ux.net> > > --- > > net/8021q/vlan.c | 8 +------- > > 1 file changed, 1 insertion(+), 7 deletions(-) > > > > diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c > > index f292e0267bb9..683e9e825b9e 100644 > > --- a/net/8021q/vlan.c > > +++ b/net/8021q/vlan.c > > @@ -36,15 +36,10 @@ > > #include "vlan.h" > > #include "vlanproc.h" > > > > -#define DRV_VERSION "1.8" > > - > > /* Global VLAN variables */ > > > > unsigned int vlan_net_id __read_mostly; > > > > -const char vlan_fullname[] = "802.1Q VLAN Support"; > > -const char vlan_version[] = DRV_VERSION; > > - > > /* End of global variables definitions. */ > > > > static int vlan_group_prealloc_vid(struct vlan_group *vg, > > @@ -687,7 +682,7 @@ static int __init vlan_proto_init(void) > > { > > int err; > > > > - pr_info("%s v%s\n", vlan_fullname, vlan_version); > > + pr_info("802.1Q VLAN Support\n"); > > How do we feel about deleting this not really informative message > altogether in a future patch? It too should be removed. If drivers are working properly, they are quiet.
Powered by blists - more mailing lists