netdev - Re: [PATCH V4 net-next 7/9] net: ena: introduce XDP redirect implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201205161559.3c817842@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Sat, 5 Dec 2020 16:15:59 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     <akiyano@...zon.com>
Cc:     <davem@...emloft.net>, <netdev@...r.kernel.org>, <dwmw@...zon.com>,
        <zorik@...zon.com>, <matua@...zon.com>, <saeedb@...zon.com>,
        <msw@...zon.com>, <aliguori@...zon.com>, <nafea@...zon.com>,
        <gtzalik@...zon.com>, <netanel@...zon.com>, <alisaidi@...zon.com>,
        <benh@...zon.com>, <ndagan@...zon.com>, <shayagr@...zon.com>,
        <sameehj@...zon.com>
Subject: Re: [PATCH V4 net-next 7/9] net: ena: introduce XDP redirect
 implementation

On Fri, 4 Dec 2020 14:11:13 +0200 akiyano@...zon.com wrote:
> +	case XDP_REDIRECT:
> +		xdp_do_redirect(rx_ring->netdev, xdp, xdp_prog);
> +		xdp_stat = &rx_ring->rx_stats.xdp_redirect;
> +		break;

Don't you have to check if xdp_do_redirect() returned an error or not?

You should CC XDP maintainers on the XDP patches.