netdev - Re: [PATCH ethtool v2] Improve error message when SFP module is missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201206184028.fi7ttyyqkmjwnrnj@lion.mk-sys.cz>
Date:   Sun, 6 Dec 2020 19:40:28 +0100
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Baruch Siach <baruch@...s.co.il>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH ethtool v2] Improve error message when SFP module is
 missing

On Wed, Dec 02, 2020 at 07:22:14PM +0200, Baruch Siach wrote:
> ETHTOOL_GMODULEINFO request success indicates that SFP cage is present.
> Failure of ETHTOOL_GMODULEEEPROM is most likely because SFP module is
> not plugged in. Add an indication to the user as to what might be the
> reason for the failure.
> 
> Signed-off-by: Baruch Siach <baruch@...s.co.il>

Applied (with minor whitespace formatting cleanup), thank you.

Michal

> ---
> v2: Limit message to likely errno values (Andrew Lunn)
> ---
>  ethtool.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/ethtool.c b/ethtool.c
> index 1d9067e774af..63b3a095eded 100644
> --- a/ethtool.c
> +++ b/ethtool.c
> @@ -4855,7 +4855,11 @@ static int do_getmodule(struct cmd_context *ctx)
>  	eeprom->offset = geeprom_offset;
>  	err = send_ioctl(ctx, eeprom);
>  	if (err < 0) {
> +		int saved_errno = errno;
>  		perror("Cannot get Module EEPROM data");
> +		if (saved_errno == ENODEV || saved_errno == EIO ||
> +				saved_errno == ENXIO)
> +			fprintf(stderr, "SFP module not in cage?\n");
>  		free(eeprom);
>  		return 1;
>  	}
> -- 
> 2.29.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)