netdev - Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201207151906.GA30105@hoboy.vegasvil.org>
Date:   Mon, 7 Dec 2020 07:19:06 -0800
From:   Richard Cochran <richardcochran@...il.com>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     Eran Ben Elisha <eranbe@...dia.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>
Subject: Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

On Mon, Dec 07, 2020 at 12:37:45AM -0800, Saeed Mahameed wrote:

> we are not adding any new mechanism.

Sorry, I didn't catch the beginning of this thread.  Are you proposing
adding HWTSTAMP_TX_ON_TIME_CRITICAL_ONLY to net_tstamp.h ?

If so, then ...

> Our driver feature is and internal enhancement yes, but the suggested
> flag is very far from indicating any internal enhancement, is actually
> an enhancement to the current API, and is a very simple extension with
> wide range of improvements to all layers.

No, that would be no enhancement but rather a hack for poorly designed
hardware.
 
> Our driver can optimize accuracy when this flag is set, other drivers
> might be happy to implement it since they already have a slow hw

Name three other drivers that would "be happy" to implement this.  Can
you name even one other?

Thanks,
Richard