netdev - Re: [PATCH net-next v4] devlink: Add devlink port documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201207094012.5853ff07@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Mon, 7 Dec 2020 09:40:12 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Parav Pandit <parav@...dia.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "jacob.e.keller@...el.com" <jacob.e.keller@...el.com>,
        Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net-next v4] devlink: Add devlink port documentation

On Mon, 7 Dec 2020 04:46:14 +0000 Parav Pandit wrote:
> > From: Jakub Kicinski <kuba@...nel.org>
> > Sent: Sunday, December 6, 2020 1:57 AM
> > 
> > On Thu, 3 Dec 2020 20:02:55 +0200 Parav Pandit wrote:  
> > > Added documentation for devlink port and port function related commands.
> > >
> > > Signed-off-by: Parav Pandit <parav@...dia.com>
> > > Reviewed-by: Jiri Pirko <jiri@...dia.com>
> > > Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>  
> >   
> > > +============
> > > +Devlink Port
> > > +============
> > > +
> > > +``devlink-port`` is a port that exists on the device.  
> > 
> > Can we add something like:
> > 
> > Each port is a logically separate ingress/egress point of the device.
> > 
> > ?  
> This may not be true when both physical ports are under bond.

Bonding changes forwarding logic, not what points of egress ASIC has.

> > > Such PCI function consists
> > > +of one or more networking ports.  
> > 
> > PCI function consists of networking ports? What do you mean by a networking
> > port? All devlink ports are networking ports.
> >  
> I am not sure this document should be a starting point to define such restriction.

Well it's the reality today. Adding "networking" everywhere in this
document is pointless.

> > > A networking port of such PCI function is
> > > +represented by the eswitch devlink port.  
> > 
> > What's eswitch devlink port? It was never defined.  
> Eswitch devlink port is the port which sets eswitch attributes (id and length).

You mean phys_port_id?

> > > before
> > > +enumerating the function.  
> > 
> > What does this mean? What does enumerate mean in this context?
> >   
> Enumerate means before creating the device of the function.
> However today due to SR-IOV limitation, it is before probing the function device.

Can you rephrase to make the point clearer?

> > > For example user may set the hardware address of
> > > +the function represented by the devlink port function.  
> > 
> > What's a hardware address? You mean MAC address?  
> Yes, MAC address.
> Port function attribute is named as hardware address to be generic enough similar to other iproute2 tools.

Right, but in iproute2 the context makes it clear. Here we could be
talking about many things.