netdev - Re: [PATCH V4 net-next 7/9] net: ena: introduce XDP redirect implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <pj41zl360hzaq0.fsf@u68c7b5b1d2d758.ant.amazon.com>
Date:   Mon, 7 Dec 2020 21:18:15 +0200
From:   Shay Agroskin <shayagr@...zon.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <akiyano@...zon.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <dwmw@...zon.com>, <zorik@...zon.com>,
        <matua@...zon.com>, <saeedb@...zon.com>, <msw@...zon.com>,
        <aliguori@...zon.com>, <nafea@...zon.com>, <gtzalik@...zon.com>,
        <netanel@...zon.com>, <alisaidi@...zon.com>, <benh@...zon.com>,
        <ndagan@...zon.com>, <sameehj@...zon.com>
Subject: Re: [PATCH V4 net-next 7/9] net: ena: introduce XDP redirect
 implementation


Jakub Kicinski <kuba@...nel.org> writes:

> On Fri, 4 Dec 2020 14:11:13 +0200 akiyano@...zon.com wrote:
>> +	case XDP_REDIRECT:
>> +		xdp_do_redirect(rx_ring->netdev, xdp, xdp_prog);
>> +		xdp_stat = &rx_ring->rx_stats.xdp_redirect;
>> +		break;
>
> Don't you have to check if xdp_do_redirect() returned an error 
> or not?
>
> You should CC XDP maintainers on the XDP patches.

Thanks for reviewing the code (:
I'll add a return value check next patchset and CC XDP 
maintainers.