lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 07 Dec 2020 20:10:06 +0000 From: patchwork-bot+netdevbpf@...nel.org To: Cong Wang <xiyou.wangcong@...il.com> Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, wangdongdong.6@...edance.com, tgraf@...g.ch, alexei.starovoitov@...il.com, cong.wang@...edance.com Subject: Re: [Patch net v2 1/2] lwt: disable BH too in run_lwt_bpf() Hello: This series was applied to bpf/bpf.git (refs/heads/master): On Fri, 4 Dec 2020 23:59:45 -0800 you wrote: > From: Dongdong Wang <wangdongdong.6@...edance.com> > > The per-cpu bpf_redirect_info is shared among all skb_do_redirect() > and BPF redirect helpers. Callers on RX path are all in BH context, > disabling preemption is not sufficient to prevent BH interruption. > > In production, we observed strange packet drops because of the race > condition between LWT xmit and TC ingress, and we verified this issue > is fixed after we disable BH. > > [...] Here is the summary with links: - [net,v2,1/2] lwt: disable BH too in run_lwt_bpf() https://git.kernel.org/bpf/bpf/c/d9054a1ff585 - [net,v2,2/2] lwt_bpf: replace preempt_disable() with migrate_disable() https://git.kernel.org/bpf/bpf/c/e3366884b383 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Powered by blists - more mailing lists