netdev - Re: [PATCH net] net: openvswitch: fix TTL decrement exception action execution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <448E9944-DAF8-4B52-9752-5F06132E1690@redhat.com>
Date:   Mon, 07 Dec 2020 10:45:27 +0100
From:   "Eelco Chaudron" <echaudro@...hat.com>
To:     "Jakub Kicinski" <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, dev@...nvswitch.org,
        pshelar@....org, bindiyakurle@...il.com, mcroce@...ux.microsoft.com
Subject: Re: [PATCH net] net: openvswitch: fix TTL decrement exception action
 execution



On 5 Dec 2020, at 1:30, Jakub Kicinski wrote:

> On Fri,  4 Dec 2020 07:16:23 -0500 Eelco Chaudron wrote:
>> Currently, the exception actions are not processed correctly as the 
>> wrong
>> dataset is passed. This change fixes this, including the misleading
>> comment.
>>
>> In addition, a check was added to make sure we work on an IPv4 
>> packet,
>> and not just assume if it's not IPv6 it's IPv4.
>>
>> Small cleanup which removes an unsessesaty parameter from the
>> dec_ttl_exception_handler() function.
>
> No cleanups in fixes, please. Especially when we're at -rc6..
>
> You can clean this up in net-next within a week after trees merge.

Ack, will undo the parameter removal, and sent out a v2.

>> Fixes: 69929d4c49e1 ("net: openvswitch: fix TTL decrement action 
>> netlink message format")
>
> :(
> and please add some info on how these changes are tested.

Will add the details to v2.